Skip to content

Comments

[action] [PR:1087] Fix mocktests for buster builds#69

Merged
prabhataravind merged 1 commit intoAzure:202506from
mssonicbld:cherry/msft-202506/1087
Oct 10, 2025
Merged

[action] [PR:1087] Fix mocktests for buster builds#69
prabhataravind merged 1 commit intoAzure:202506from
mssonicbld:cherry/msft-202506/1087

Conversation

@mssonicbld
Copy link
Collaborator

  • PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_P. This change fixes the error below related to #1084
   tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token INSTANTIATE_TEST_SUITE_P( ^ tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
         PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
                                                        ^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
         PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
                          ^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
     )
     ^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1

 * PTF build still uses buster which does not support INSTANTIATE_TEST_SUITE_P. This change fixes the error below related to #1084

```
   tests/zmq_state_ut.cpp:698:25: error: expected constructor, destructor, or type conversion before '(' token INSTANTIATE_TEST_SUITE_P( ^ tests/zmq_state_ut.cpp:702:56: error: expected unqualified-id before ',' token
         PopSizeTestParams{40, 150, 4, {40, 40, 40, 30}},
                                                        ^
tests/zmq_state_ut.cpp:703:26: error: expected constructor, destructor, or type conversion before '{' token
         PopSizeTestParams{-1, 384, 3, {128, 128, 128}}
                          ^
tests/zmq_state_ut.cpp:704:5: error: expected unqualified-id before ')' token
     )
     ^
make[4]: *** [Makefile:2683: tests/tests-zmq_state_ut.o] Error 1
```
@mssonicbld
Copy link
Collaborator Author

Original PR: sonic-net/sonic-swss-common#1087

@mssonicbld
Copy link
Collaborator Author

/azp run

@prabhataravind
Copy link

prabhataravind commented Oct 10, 2025

/azpw run

@prabhataravind prabhataravind merged commit 760b201 into Azure:202506 Oct 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants